Project

General

Profile

Bug #89

changing *from* a template with containers

Added by Harris Lapiroff about 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Category:
Admin
Target version:
-
Start date:
02/22/2011
Due date:
% Done:

0%

Estimated time:

Description

Steps to reproduce:

  1. In the admin, create a template with containers and a template without.
  2. Create a page using the template with containers. Save it.
  3. Change the page to use the template without containers. Save it.

If I've correctly identified the problem, you'll get an IndexError.

Associated revisions

Revision f7ea1694 (diff)
Added by Stephen Burrows about 13 years ago

Refactored ContainerForms to reflect a more suitable structure by storing the containers internally as a SortedDict. By handling containers more consistently, this commit resolves issue #89.

Revision 3269dd07
Added by Joseph Spiros about 13 years ago

Merge branch 'master' of git://github.com/melinath/philo

  • 'master' of git://github.com/melinath/philo:
    Added feed length limit to FeedView. Implements feature #111.
    Corrected LazyNavigationRecurser to mark its return value as safe.
    Switched back to setting a {{ children }} variable, but set it to a lazy recurser instead of a rendered result. Switched item and children to be set in the context directly for easy access. Improved/updated recursenavigation docstring.
    Refactored the RecurseNavigationNode to have less repetition. Switched from {{ children }} to {% recurse %} because it makes more sense to collect recursion only if needed.
    Added a number of counting variables to the context when rendering shipherd navigation. Designed to mirror the variables generated when using a for loop.
    Minor corrections to shipherd recursenavigation docstring.
    Added CSRF cookie js to TagCreation.js... apparently it isn't in the admin by default. Resolves issue 83.
    Added an admin action to NewsletterArticleAdmin to handle creating a NewsletterIssue from a selection of articles. Resolves issue 82.
    Minor LazyContainerFinder cleanup. It's not really that lazy in practice...
    Removed nodelist_crawl since nothing is using it and I'm starting to question its usefulness in general.
    Built a clearer algorithm for finding a template's containers; added support for template block overrides cancelling out containers in that block, which resolves issue #90.
    Corrected FeedView handling of incorrect Accept headers. Will now actually return 406 errors.
    Genericized nodelist_crawl to just pass each node to a callback function. Overloaded the Template.containers callback to create a blockcontext for handling containers in overridden blocks as per issue 90 and to handle contentreference/contentlet generation in a single sweep.
    Refactored ContainerForms to reflect a more suitable structure by storing the containers internally as a SortedDict. By handling containers more consistently, this commit resolves issue #89.
    Removed apparently-vestigial Entity.attribute property.

Revision 834e27b6
Added by Joseph Spiros about 13 years ago

Merge branch 'master' into gilbert

  • master: (25 commits)
    Added feed length limit to FeedView. Implements feature #111.
    Corrected LazyNavigationRecurser to mark its return value as safe.
    Switched back to setting a {{ children }} variable, but set it to a lazy recurser instead of a rendered result. Switched item and children to be set in the context directly for easy access. Improved/updated recursenavigation docstring.
    Refactored the RecurseNavigationNode to have less repetition. Switched from {{ children }} to {% recurse %} because it makes more sense to collect recursion only if needed.
    Added a number of counting variables to the context when rendering shipherd navigation. Designed to mirror the variables generated when using a for loop.
    Minor corrections to shipherd recursenavigation docstring.
    Added CSRF cookie js to TagCreation.js... apparently it isn't in the admin by default. Resolves issue 83.
    Added an admin action to NewsletterArticleAdmin to handle creating a NewsletterIssue from a selection of articles. Resolves issue 82.
    Minor LazyContainerFinder cleanup. It's not really that lazy in practice...
    Removed nodelist_crawl since nothing is using it and I'm starting to question its usefulness in general.
    Built a clearer algorithm for finding a template's containers; added support for template block overrides cancelling out containers in that block, which resolves issue #90.
    Corrected FeedView handling of incorrect Accept headers. Will now actually return 406 errors.
    Genericized nodelist_crawl to just pass each node to a callback function. Overloaded the Template.containers callback to create a blockcontext for handling containers in overridden blocks as per issue 90 and to handle contentreference/contentlet generation in a single sweep.
    Refactored ContainerForms to reflect a more suitable structure by storing the containers internally as a SortedDict. By handling containers more consistently, this commit resolves issue #89.
    Removed apparently-vestigial Entity.attribute property.
    Corrected JSONValue.__unicode__ to return unicode instead of bytestrings... not sure what it was being modeled on. Tweaked TargetURLModel to use smart_str instead of str to construct the Python < 2.6.5 kwargs to get a more consistent byte string.
    Corrected WaldoAuthenticationForm.clean to handle lack of password/username. Moved password-related forms into a class attribute for customizability. Standardized confirmation email context and allowed for a secure confirmation link.
    Tweaked TargetURLModel.get_reverse_params() to convert kwargs keys to bytestrings to support Python versions prior to 2.6.5
    Minor correction to BlogView.urlpatterns.
    Switched feed_patterns to return urlpatterns suitable for addition to urlpatterns instead of inclusion in urlpatterns. Adjusted penfield urlpatterns accordingly. Added default behavior for FeedView.get_feed in cases where a known feed_type is not supplied for whatever reason. Added RegistrationMultiView.registration_form attribute.
    ...

History

#1

Updated by Stephen Burrows about 13 years ago

  • Status changed from New to Resolved

Fixed with commit f7ea1694cd74b49f8220e422291830a758521824

Also available in: Atom PDF