Project

General

Profile

Bug #71

Philo's attribute fields no longer work in Django 1.3

Added by Stephen Burrows over 13 years ago. Updated about 13 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Admin
Target version:
-
Start date:
01/19/2011
Due date:
% Done:

0%

Estimated time:

Description

In the future, philo may be used with django 1.3. Right now, the proxy field use enabled by the EntityForm is not possible in Django 1.3 - it looks like the ModelAdmin validation may be stricter.

Associated revisions

Revision 3a134160 (diff)
Added by Stephen Burrows about 13 years ago

Resolves issue #71 for the admin interface by working around the use of modelform_factory. If any code uses modelform_factory elsewhere with an entity form, the same issue will arise. Also compatible with 1.2.X.

Revision a917b5dd
Added by Joseph Spiros about 13 years ago

Merge branch 'master' of git://github.com/melinath/philo

  • 'master' of git://github.com/melinath/philo: (31 commits)
    Improved TemplateValidator error reporting to include origins and line numbers in TemplateSyntaxError reports.
    Resolves issue 68 by treating any incorrectly-passed-in values for JSON fields as json strings rather than as python objects.
    Resolved issue #120 by removing detection of containers which would not be rendered.
    Made uuid of event autogenerated. Fully resolves issue #119. Also had to reset julian migrations again.
    Julian improvements: Made calendar events optional and made calendar feed uuids auto-generated. Reset the migrations because south wasn't cooperating.
    Adjusted 14082 hack again... "fixed" the ModelFormMetaclass.__new__ method and wrote EntityFormMetaclass as if there was no issue.
    Moved the EventQuerySet to its own class instead of nesting it in the Event model.
    Removed python 2.4 compatibility workaround use, since this is removed in Django 1.3 and philo doesn't support python 2.4 anyway.
    Resolves issue #71 for the admin interface by working around the use of modelform_factory. If any code uses modelform_factory elsewhere with an entity form, the same issue will arise. Also compatible with 1.2.X.
    Improved proxy-field hiding to be 1.3-proof. Unfortunately, requires a attribute on the proxy admin, but it seems like the best way. Still backwards-compatible with 1.2.X.
    Removed shipherd navigation_host filter exception reraising. Tweaked LazyNode - turns out the / needs to be prepended before trying to check if the node handles_subpath.
    Added some convenient methods to event querysets.
    Switched Template.__unicode__ to only return self.name for legibility.
    Corrected node_view redirection of trailing slashes to non-trailing slashes to rely on request._cached_node_path instead of request.path. Tweaked LazyNode to only return a found node if it handles the found subpath.
    Added feed_length to BlogViewAdmin.
    Solidified AJAX API.
    Prettified results page. Added search results templates for grappelli and the normal admin.
    Refactored weight code to split the work over Search, ResultURL, and Click models. This is probably somewhat less efficient, but it makes more intuitive sense. It also allows for weight caching on instances. Initial work on a results action/view for the SearchAdmin. Set SearchView to have SearchForm set as an attribute on itself rather than blindly using it.
    First attempts at a get_favored_results method to find what people are generally selecting. Some minor aesthetic changes. Changed ajax api template fetch to call get_template with the intent of passing an argument as to whether it should be prepped for ajax.
    Updated CalendarView urlpatterns to use the new feed_patterns method.
    ...

History

#1

Updated by Stephen Burrows over 13 years ago

It's not a problem with modeladmin validation - rather, it's an issue with ModelFormMetaclass. The new method now checks to make sure all fields defined in the Meta class are actually fields on the model. Mrf. It might be simpler to just override the entire meta method.

#2

Updated by Stephen Burrows about 13 years ago

  • Status changed from New to Resolved

Resolved for the admin with commit 3a134160f8e7e663c5807cd44296f5f3a88b8a36

Also available in: Atom PDF