Project

General

Profile

Bug #144

Refactor LazyNode use in middleware to use SimpleLazyObject

Added by Stephen Burrows almost 13 years ago. Updated almost 13 years ago.

Status:
Resolved
Priority:
High
Category:
Core
Target version:
-
Start date:
06/01/2011
Due date:
% Done:

0%

Estimated time:

Description

It would be more efficient (both in terms of code maintainance and potentially also in speed) to use the built-in tools more and to follow django's lead on this one. This could go into the release since it's not a 'feature' per se.

Compare/reference:

http://groups.google.com/group/django-developers/browse_thread/thread/f57fad3c0b467f76
https://code.djangoproject.com/changeset/16297
https://code.djangoproject.com/changeset/16305

Associated revisions

Revision 1d21b0f7 (diff)
Added by Stephen Burrows almost 13 years ago

Refactored RequestNodeMiddleware to use SimpleLazyObject - comparable to django r16297/r16305. Resolves issue #144.

Revision ac8a3258
Added by Joseph Spiros almost 13 years ago

Merge branch 'master' of git://github.com/melinath/philo

  • 'master' of git://github.com/melinath/philo:
    Implemented the solution proposed to #130 - removed TreeModel and made a SlugTreeEntity subclass of TreeEntity to handle Node and Template. Correctly subclassed SlugTreeEntity.Meta so that Node and Template actually have the unique constraints they are meant to. Minor correction to TreeEntity.get_path.
    Minor corrections to TagCreation.js. Resolves issue #125.
    Switched contentlets to use lists rather than sets to preserve ordering. Resolves issue #132. Added some basic tests for containers. Moved build_extension_tree out of Template.containers.
    Minor correction to FeedView docstrings. Resolves issue #139.
    Refactored RequestNodeMiddleware to use SimpleLazyObject - comparable to django r16297/r16305. Resolves issue #144.
    Corrected philo tests and removed all use of penfield models in those tests - resolves issue #80. Minor correction to TreeModel.get_path to save a query.
    Added a 'getting started' tutorial and a short intro to philo page to the docs. Improved Attribute docstring.

History

#1

Updated by Stephen Burrows almost 13 years ago

  • Status changed from New to Resolved

Resolved with commit 1d21b0f7b336f5761e570023d64d413748b07cc1.

Also available in: Atom PDF