Project

General

Profile

Bug #67

TreeManager.get_with_path does not return path remainders for the root node

Added by Joseph Spiros over 13 years ago. Updated over 13 years ago.

Status:
Resolved
Priority:
Urgent
Category:
-
Target version:
-
Start date:
01/06/2011
Due date:
% Done:

0%

Estimated time:

Description

When TreeManager.get_with_path is called with a valid root node, absolute_result=False, and a path that does not resolve to a node, rather than returning the root node and the entire path as the remainder, it raises a DoesNotExist exception.

This is a bug as it breaks the functionality of root nodes with a View that accepts a subpath.

History

#1

Updated by Joseph Spiros over 13 years ago

  • Assignee set to Stephen Burrows

While an obvious solution would be adding a try/except block around the last line of the current implementation of get_with_path, I'm not sure if you have any interest in refactoring beyond that.

#2

Updated by Stephen Burrows over 13 years ago

  • Status changed from New to Resolved

This was resolved back with commit c7571f163bfae1c2dcfd4fbfa8e43ac7cd3fdcff.

#3

Updated by Stephen Burrows over 13 years ago

https://github.com/melinath/philo/commit/c7571f163bfae1c2dcfd4fbfa8e43ac7cd3fdcff
(It hasn't been pulled to the blessed repository yet, though.)

#4

Updated by Joseph Spiros over 13 years ago

Merged into blessed repository in commit commit: e095f691f243784f8c8d0a9773270b9dbead18e9.

Also available in: Atom PDF